Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom data type and custom JSON serialization for traceid #1840

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Use custom data type and custom JSON serialization for traceid #1840

merged 1 commit into from
Sep 24, 2020

Commits on Sep 23, 2020

  1. Use custom data type and custom JSON serialization for traceid 

    Contributes to open-telemetry#1177

1. The TraceID type uses custom data type so that JSON serialization
is in hex format instead of base64 (which is the default Protobuf JSON
format). Hex format is required by OTLP spec:
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/protocol/otlp.md#request
SpanID must be also modified similarly. Will be done in a future PR
to avoid creating a huge PR.

2. Moved pdata.TraceID to its own file. Note that there is pdata.TraceID which
is different from otlp TraceID custom data type. Due to the way packages are
structured we need both to keep OTLP generated data types decoupled from pdata
data types.

The majority of the changes in this commit are simply type changes from
[]byte to TraceID.
    Tigran Najaryan committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    d1c3838 View commit details
    Browse the repository at this point in the history