Begin implementation of OTLP/HTTP exporter #1928
Conversation
tigrannajaryan
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais and
pjanotti
as code owners
tigrannajaryan
changed the title
tigrannajaryan
force-pushed
the
feature/tigran/otlp_http
branch
from
b7c9c80 to
0cbf345
Compare
Codecov Report
@@ Coverage Diff @@
## master #1928 +/- ##
==========================================
- Coverage 91.39% 91.24% -0.15%
==========================================
Files 284 286 +2
Lines 16740 16841 +101
==========================================
+ Hits 15299 15367 +68
- Misses 1009 1036 +27
- Partials 432 438 +6
Continue to review full report at Codecov.
|
| - `key_file` path to the TLS key to use for TLS required connections. Should | ||
| only be used if `insecure` is set to false. | ||
| - `timeout` (default = 30s): How long to wait until the connection is close. | ||
| - `read_buffer_size` (default = 0): ReadBufferSize for HTTP client. |
There was a problem hiding this comment.
Given that reads are for error reporting purposes (I'm assuming), is it really so important to be able to configure the read buffer size?
There was a problem hiding this comment.
Not important, but it already exists in the HTTPClientSettings. Perhaps we can keep it undocumented to avoid overloading the users with unnecessary settings?
tigrannajaryan
force-pushed
the
feature/tigran/otlp_http
branch
3 times, most recently
from
0718230 to
b1c6894
Compare
This adds the initial config and factory boilerplate and corresponding tests. Contributes to: open-telemetry#882 Testing: config and factory tests unit tests added. Documentation: Added README. The next PR will add the exporting logic.
tigrannajaryan
force-pushed
the
feature/tigran/otlp_http
branch
from
b1c6894 to
85e217e
Compare
| type sender interface { | ||
| exportTrace(ctx context.Context, request *otlptrace.ExportTraceServiceRequest) error | ||
| exportMetrics(ctx context.Context, request *otlpmetrics.ExportMetricsServiceRequest) error | ||
| exportLogs(ctx context.Context, request *otlplogs.ExportLogsServiceRequest) error | ||
| stop() error | ||
| } |
There was a problem hiding this comment.
This interface is no longer required, was added with the idea that both grpc and http will be in the same exporter. Needs to be removed from grpc as well.
There was a problem hiding this comment.
Created the PR to remove from grpc #1933
This adds the initial config and factory boilerplate and corresponding tests.
The next PR will add the exporting logic.
Contributes to: #882
Added README.