-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added array serialization to logging_exporter #1994
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1994 +/- ##
==========================================
+ Coverage 91.49% 91.51% +0.01%
==========================================
Files 282 282
Lines 16631 16641 +10
==========================================
+ Hits 15217 15229 +12
+ Misses 978 976 -2
Partials 436 436
Continue to review full report at Codecov.
|
The CI check that's failing does not appear related to this change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
…y#1994) Bumps [boto3](https://github.com/boto/boto3) from 1.24.74 to 1.24.75. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.24.74...1.24.75) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description: Bug fix - adds serialization of array attributes, including nested arrays, in the
logging_exporter
. This allows them to be printed like the primitive attribute types when debugging. AFAICT, there aren't any attributes with array values today, but they are permitted types in the spec, and I will be contributing a resource detector that uses array attributes in the future.Testing: Added unit test