Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added array serialization to logging_exporter #1994

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

willarmiros
Copy link
Contributor

Description: Bug fix - adds serialization of array attributes, including nested arrays, in the logging_exporter. This allows them to be printed like the primitive attribute types when debugging. AFAICT, there aren't any attributes with array values today, but they are permitted types in the spec, and I will be contributing a resource detector that uses array attributes in the future.

Testing: Added unit test

@willarmiros willarmiros requested a review from a team October 21, 2020 20:05
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #1994 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1994      +/-   ##
==========================================
+ Coverage   91.49%   91.51%   +0.01%     
==========================================
  Files         282      282              
  Lines       16631    16641      +10     
==========================================
+ Hits        15217    15229      +12     
+ Misses        978      976       -2     
  Partials      436      436              
Impacted Files Coverage Δ
exporter/loggingexporter/logging_exporter.go 89.96% <100.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a4455...a4b7a38. Read the comment docs.

@willarmiros
Copy link
Contributor Author

The CI check that's failing does not appear related to this change:

# github.com/logzio/jaeger-logzio/store
/home/circleci/go/pkg/mod/github.com/logzio/jaeger-logzio@v0.0.0-20200826115713-de8961d427e3/store/store.go:41:14: cannot use store.writer (type *LogzioSpanWriter) as type spanstore.Writer in return argument:
	*LogzioSpanWriter does not implement spanstore.Writer (wrong type for WriteSpan method)
		have WriteSpan(*model.Span) error
		want WriteSpan(context.Context, *model.Span) error
/home/circleci/go/pkg/mod/github.com/logzio/jaeger-logzio@v0.0.0-20200826115713-de8961d427e3/store/store.go:46:14: cannot use store.reader (type *LogzioSpanReader) as type dependencystore.Reader in return argument:
	*LogzioSpanReader does not implement dependencystore.Reader (wrong type for GetDependencies method)
		have GetDependencies(time.Time, time.Duration) ([]model.DependencyLink, error)
		want GetDependencies(context.Context, time.Time, time.Duration) ([]model.DependencyLink, error)
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter [build failed]

Copy link
Contributor

@jrcamp jrcamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

exporter/loggingexporter/logging_exporter.go Outdated Show resolved Hide resolved
@jrcamp jrcamp self-assigned this Oct 26, 2020
@tigrannajaryan tigrannajaryan merged commit c6c96f7 into open-telemetry:master Oct 27, 2020
@willarmiros willarmiros deleted the log-arrays branch October 27, 2020 17:06
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#1994)

Bumps [boto3](https://github.com/boto/boto3) from 1.24.74 to 1.24.75.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.24.74...1.24.75)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants