Change default OTLP port number #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
==========================================
- Coverage 92.23% 92.19% -0.04%
==========================================
Files 280 280
Lines 16977 17003 +26
==========================================
+ Hits 15658 15676 +18
- Misses 904 910 +6
- Partials 415 417 +2
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Nov 12, 2020
tigrannajaryan
force-pushed
the
feature/tigran/otlp-port-transition
branch
from
dbe5792
to
a4a1a4a
Compare
Removed. |
bogdandrutu
reviewed
Nov 13, 2020
tigrannajaryan
force-pushed
the
feature/tigran/otlp-port-transition
branch
from
a4a1a4a
to
cfe828d
Compare
|
@open-telemetry/collector-approvers please review. |
tigrannajaryan
changed the title
tigrannajaryan
force-pushed
the
feature/tigran/otlp-port-transition
branch
from
cfe828d
to
b5efd85
Compare
bogdandrutu
reviewed
Nov 18, 2020
This implements specification change open-telemetry/opentelemetry-specification#1221 To make transition to new port numbers less painful OTLP receiver will also accept data on the legacy port numbers when it is configured to use the default endpoint. Users who use the default Collector config can continue sending data to the legacy ports and have a graceful period to update their senders to start sending to the new ports. Note that OTLP/HTTP continues using a separate port number from OTLP/gRPC. There is separate work in progress to use one port for both.
tigrannajaryan
force-pushed
the
feature/tigran/otlp-port-transition
branch
from
b5efd85
to
2d8f1a8
Compare
|
@bogdandrutu PTAL. |
bogdandrutu
approved these changes
Nov 19, 2020
This was referenced Apr 9, 2021
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…ts (open-telemetry#2104) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements specification change open-telemetry/opentelemetry-specification#1221
To make transition to new port numbers less painful OTLP receiver will
also accept data on the legacy port numbers when it is configured to
use the default endpoint. Users who use the default Collector config
can continue sending data to the legacy ports and have a graceful period
to update their senders to start sending to the new ports.
Note that OTLP/HTTP continues using a separate port number from OTLP/gRPC.
There is separate work in progress to use one port for both.
This must be merged after open-telemetry/opentelemetry-specification#1221 is merged.