Remove legacy metrics, they were marked as legacy for ~12 months #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2105 +/- ##
==========================================
- Coverage 92.15% 92.10% -0.05%
==========================================
Files 279 279
Lines 17077 17024 -53
==========================================
- Hits 15737 15680 -57
- Misses 921 925 +4
Partials 419 419
Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
Nov 10, 2020
Fixes open-telemetry#1082 This PR removes: - Legacy receiver/exporter metrics: - otelcol/receiver/received_spans - otelcol/receiver/dropped_spans - otelcol/receiver/received_timeseries - otelcol/receiver/dropped_timeseries - otelcol/exporter/received_spans - otelcol/exporter/dropped_spans - otelcol/exporter/received_timeseries - otelcol/exporter/dropped_timeseries - otelcol/exporter/received_logs - otelcol/exporter/dropped_logs - For processors remove the legacy metrics (new metrics have the same data, different names): - e.g. "spans_dropped" -> "processor/spans_dropped" - e.g. "batch_send_size_bytes" -> "processor/batch/batch_send_size_bytes" All the new metrics were enabled when using the --new-metrics flag. The PR also removes two flags: - "--new-metrics" - "--legacy-metrics" Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
rmlegacy
branch
from
6efe32c
to
f1dd2fd
Compare
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Remove several metrics test helpers * Lint * Changelog * Lint
This was referenced Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1082
This PR removes:
All the new metrics were enabled when using the --new-metrics flag. The PR also removes two flags:
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com