Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "process/memory/rss" metric units #2112

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Conversation

tigrannajaryan
Copy link
Member

This metric is in bytes, it was incorrectly marked as unitless.

This metric is in bytes, it was incorrectly marked as unitless.
@tigrannajaryan tigrannajaryan requested a review from a team November 10, 2020 23:45
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #2112 (149a54e) into master (d322a41) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
+ Coverage   92.10%   92.11%   +0.01%     
==========================================
  Files         279      279              
  Lines       17024    17024              
==========================================
+ Hits        15680    15682       +2     
+ Misses        925      924       -1     
+ Partials      419      418       -1     
Impacted Files Coverage Δ
service/internal/telemetry/process_telemetry.go 82.05% <ø> (ø)
translator/internaldata/resource_to_oc.go 94.36% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d322a41...149a54e. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 15ea413 into master Nov 12, 2020
@tigrannajaryan tigrannajaryan deleted the tigrannajaryan-patch-1 branch November 12, 2020 15:44
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants