Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplicate code in components helper #2186

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

bogdandrutu
Copy link
Member

Add componenthelper package to help building components like Processors, Exporters.

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team November 20, 2020 00:12
Add componenthelper package to help building components like Processors, Exporters.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #2186 (c8deaa1) into master (29859f2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2186      +/-   ##
==========================================
+ Coverage   91.99%   92.00%   +0.01%     
==========================================
  Files         270      271       +1     
  Lines       15791    15790       -1     
==========================================
+ Hits        14527    14528       +1     
+ Misses        860      859       -1     
+ Partials      404      403       -1     
Impacted Files Coverage Δ
exporter/exporterhelper/logshelper.go 100.00% <ø> (ø)
exporter/exporterhelper/metricshelper.go 94.59% <ø> (ø)
exporter/exporterhelper/tracehelper.go 100.00% <ø> (ø)
component/componenthelper/component.go 100.00% <100.00%> (ø)
exporter/exporterhelper/common.go 100.00% <100.00%> (ø)
processor/processorhelper/processor.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 91.54% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29859f2...c8deaa1. Read the comment docs.

bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 20, 2020
In a followup PR, after open-telemetry#2186 is merged, use component helper.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 20, 2020
In a followup PR, after open-telemetry#2186 is merged, use component helper.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this pull request Nov 20, 2020
In a followup PR, after #2186 is merged, use component helper.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 8ceddba into open-telemetry:master Nov 20, 2020
@bogdandrutu bogdandrutu deleted the componenthelper branch November 20, 2020 15:17
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…otlpmetric (open-telemetry#2186)

* Bump google.golang.org/grpc in /exporters/otlp/otlpmetric

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.39.1 to 1.40.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.39.1...v1.40.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants