-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce duplicate code in components helper #2186
Merged
bogdandrutu
merged 1 commit into
open-telemetry:master
from
bogdandrutu:componenthelper
Nov 20, 2020
Merged
Reduce duplicate code in components helper #2186
bogdandrutu
merged 1 commit into
open-telemetry:master
from
bogdandrutu:componenthelper
Nov 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add componenthelper package to help building components like Processors, Exporters. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
componenthelper
branch
from
November 20, 2020 00:18
8e20e5d
to
c8deaa1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2186 +/- ##
==========================================
+ Coverage 91.99% 92.00% +0.01%
==========================================
Files 270 271 +1
Lines 15791 15790 -1
==========================================
+ Hits 14527 14528 +1
+ Misses 860 859 -1
+ Partials 404 403 -1
Continue to review full report at Codecov.
|
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Nov 20, 2020
In a followup PR, after open-telemetry#2186 is merged, use component helper. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Nov 20, 2020
In a followup PR, after open-telemetry#2186 is merged, use component helper. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
that referenced
this pull request
Nov 20, 2020
In a followup PR, after #2186 is merged, use component helper. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jrcamp
approved these changes
Nov 20, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…otlpmetric (open-telemetry#2186) * Bump google.golang.org/grpc in /exporters/otlp/otlpmetric Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.39.1 to 1.40.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.39.1...v1.40.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
componenthelper
package to help building components like Processors, Exporters.Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com