Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Push functions to be consistent across signals in exporterhelper #2203

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #2203 (c02b0fe) into master (cc0a999) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2203      +/-   ##
==========================================
- Coverage   92.01%   92.00%   -0.02%     
==========================================
  Files         271      271              
  Lines       15783    15783              
==========================================
- Hits        14523    14521       -2     
- Misses        858      859       +1     
- Partials      402      403       +1     
Impacted Files Coverage Δ
exporter/exporterhelper/logshelper.go 100.00% <100.00%> (ø)
exporter/exporterhelper/metricshelper.go 94.59% <100.00%> (ø)
exporter/exporterhelper/tracehelper.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 91.54% <0.00%> (-2.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0a999...c02b0fe. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 9dc1757 into open-telemetry:master Nov 23, 2020
@bogdandrutu bogdandrutu deleted the consistentpushers branch November 23, 2020 18:12
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Update the website getting started docs

Add a new example, fib, that contains an application for the computation
of Fibonacci numbers. Use this example to update the website getting
started documentation.

* Revise docs english

* Update example/fib/go.mod

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Add a What's Next section

* Clean up intro

* Apply suggestions from code review

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Apply feedback

* Return from Poll on error

* Update website_docs/getting-started.md

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>

* Add root and parent relationship info

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants