Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated line from documentation #2233

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

trask
Copy link
Member

@trask trask commented Dec 1, 2020

Description:

Documentation for processors states:

Only match_type=strict is allowed if "attributes" are specified.

but this restriction was removed in https://github.com/open-telemetry/opentelemetry-collector/pull/928/files#diff-4548db28578c2ac90e2b277f24654cfa24fd0f99d854e0fcc4b50871c0b529caL166-R198, and so this doc appears to be outdated.

Testing:

I did not test this, but others (including @tigrannajaryan) have: #1935 (comment)

[btw, in case you're curious my interest in this, we are implementing a subset of this behavior at the java agent layer, as we aren't using otel collector. So far only in our vendor distro, though happy to move it to otel javaagent if/when others are interested.]

@trask trask requested a review from a team December 1, 2020 19:49
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #2233 (f5677db) into master (f4f68db) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2233      +/-   ##
==========================================
- Coverage   92.12%   92.11%   -0.01%     
==========================================
  Files         272      272              
  Lines       15289    15284       -5     
==========================================
- Hits        14085    14079       -6     
  Misses        828      828              
- Partials      376      377       +1     
Impacted Files Coverage Δ
internal/data/traceid.go 84.61% <0.00%> (-7.70%) ⬇️
internal/data/bytesid.go 80.95% <0.00%> (+4.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f68db...f5677db. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trask

@tigrannajaryan tigrannajaryan merged commit f7cc49d into open-telemetry:master Dec 1, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants