Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/2] Add Security workflows: GoSec scan workflow #2326

Closed

Conversation

amanbrar1999
Copy link
Contributor

@amanbrar1999 amanbrar1999 commented Dec 30, 2020

Motivation

Related to #2325 and issue open-telemetry/oteps#144

GoSec is a static analysis engine which scans go source code for security vulnerabilities. As the project grows and we near GA it might be useful to have a workflow which checks for security vulnerabilities so we can ensure every incremental change is following best development practices. Also passing basic security checks will also make sure that there aren't any glaring issues for our users.

Changes

This PR adds GoSec security checks to the repo

Workflow Triggers

  • daily cron job at 2:30am
  • workflow_dispatch (in case maintainers want to trigger a security check manually)

cc- @alolita

@amanbrar1999 amanbrar1999 requested a review from a team December 30, 2020 20:39
@amanbrar1999 amanbrar1999 changed the title [1/2] Add Security workflows: GoSec scan workflow [2/2] Add Security workflows: GoSec scan workflow Dec 30, 2020
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #2326 (f678f4b) into master (86ec919) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2326   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         273      273           
  Lines       15367    15367           
=======================================
  Hits        14141    14141           
  Misses        845      845           
  Partials      381      381           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ec919...f678f4b. Read the comment docs.

@bogdandrutu
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants