Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add k8s.node semantic conventions #2425

Merged
merged 1 commit into from
Feb 1, 2021
Merged

add k8s.node semantic conventions #2425

merged 1 commit into from
Feb 1, 2021

Conversation

jrcamp
Copy link
Contributor

@jrcamp jrcamp commented Jan 29, 2021

No description provided.

@jrcamp jrcamp requested a review from a team January 29, 2021 21:51
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #2425 (9ae9558) into main (165c3f0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2425      +/-   ##
==========================================
- Coverage   91.90%   91.90%   -0.01%     
==========================================
  Files         268      268              
  Lines       15213    15210       -3     
==========================================
- Hits        13982    13978       -4     
  Misses        854      854              
- Partials      377      378       +1     
Impacted Files Coverage Δ
translator/conventions/opentelemetry.go 100.00% <100.00%> (ø)
internal/data/traceid.go 84.61% <0.00%> (-7.70%) ⬇️
internal/data/bytesid.go 80.95% <0.00%> (+4.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165c3f0...9ae9558. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit e12dee4 into open-telemetry:main Feb 1, 2021
japoorv pushed a commit to hypertrace/opentelemetry-collector that referenced this pull request Aug 9, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
* use latest release info as exposed by github api

* simplify logic

* try another github action

* simplify logic some more

* fix path

* use version again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants