Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change goldendataset trace to return pdata #2563

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team February 26, 2021 21:57
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #2563 (832a174) into main (5459e31) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2563      +/-   ##
==========================================
- Coverage   91.71%   91.69%   -0.03%     
==========================================
  Files         267      267              
  Lines       15107    15107              
==========================================
- Hits        13856    13852       -4     
- Misses        868      871       +3     
- Partials      383      384       +1     
Impacted Files Coverage Δ
internal/goldendataset/traces_generator.go 85.91% <100.00%> (ø)
exporter/exporterhelper/metricshelper.go 94.59% <0.00%> (-5.41%) ⬇️
exporter/otlpexporter/otlp.go 71.79% <0.00%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5459e31...832a174. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 6ad7d67 into open-telemetry:main Mar 2, 2021
@bogdandrutu bogdandrutu deleted the goldentrace branch March 2, 2021 22:07
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants