Avoid exposing publicly constants from obsreport #2644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
tigrannajaryan
approved these changes
Mar 9, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
carlosalberto
approved these changes
Apr 14, 2021
|
Please resolve conflicts. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Fixed by #3253 |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#2644) * Fix exported module names to match directory locations To refer to a specific version of a module from another repo, the Go module system requires that the module path match the name of the directory path inside the repo. See https://go.dev/ref/mod#vcs-dir This requires changing the names of the exported modules to include the "pkg" prefix used in the directory structure (and in the case of smartagentextension, correcting the module name to reflect that it's in the extension subdirectory, not the receiver subdirectory). It also requires the name of the leaf directory match the module name. This commit standardizes on the naming scheme used in the OpenTelemetry Collector contrib repo, where subdirectories (and module nams) include the type of the "plugin" as a suffix to the name of the module and directory. For example: processor/timestamp => pkg/processor/timestampprocessor receiver/smartagent => pkg/receiver/smartagentreceiver * Fix docs references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com