Clarify Component lifecycle #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies the phases of the lifecycle of Component.
bogdandrutu
approved these changes
Mar 22, 2021
pjanotti
approved these changes
Mar 22, 2021
Codecov Report
@@ Coverage Diff @@
## main #2757 +/- ##
=======================================
Coverage 91.78% 91.78%
=======================================
Files 291 291
Lines 15522 15522
=======================================
Hits 14247 14247
Misses 874 874
Partials 401 401 Continue to review full report at Codecov.
|
This was referenced Mar 22, 2021
pjanotti
added a commit
to pjanotti/opentelemetry-service
that referenced
this pull request
Mar 22, 2021
bogdandrutu
pushed a commit
that referenced
this pull request
Mar 22, 2021
* Add lifecycle tests to all defaultcomponents * Remove commented code in test * Change lifecycle tests per #2757 * Use errors.Is * Remove extra lines * Remove unneeded cast function
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies the phases of the lifecycle of Component.