-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename fanoutprocessor to FanOutConnector #285
Rename fanoutprocessor to FanOutConnector #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
- Coverage 73.19% 73.08% -0.11%
==========================================
Files 111 111
Lines 6446 6446
==========================================
- Hits 4718 4711 -7
- Misses 1485 1490 +5
- Partials 243 245 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I did mention some possible rename suggestions but their scope is small, I'll leave it up to you.
This implements open-telemetry#283
ac4e9f9
to
d2ccb6d
Compare
Please have another look. |
d2ccb6d
to
1cd6662
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…#285) * bump dependent module versions. * update example hashes too.
…elemetry#287) This reverts commit c02a72c.
This implements #283