Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fanoutprocessor to FanOutConnector #285

Merged
merged 2 commits into from
Aug 23, 2019

Conversation

tigrannajaryan
Copy link
Member

This implements #283

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #285 into master will decrease coverage by 0.1%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   73.19%   73.08%   -0.11%     
==========================================
  Files         111      111              
  Lines        6446     6446              
==========================================
- Hits         4718     4711       -7     
- Misses       1485     1490       +5     
- Partials      243      245       +2
Impacted Files Coverage Δ
processor/fanoutconnector.go 100% <100%> (ø)
service/builder/receivers_builder.go 83.63% <100%> (ø) ⬆️
service/builder/pipelines_builder.go 92.72% <50%> (ø) ⬆️
exporter/opencensusexporter/opencensus.go 28.57% <0%> (-7.15%) ⬇️
receiver/zipkinreceiver/trace_receiver.go 59.4% <0%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9124c43...1cd6662. Read the comment docs.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I did mention some possible rename suggestions but their scope is small, I'll leave it up to you.

processor/fanoutconnector.go Outdated Show resolved Hide resolved
processor/fanoutconnector.go Outdated Show resolved Hide resolved
processor/fanoutconnector_test.go Outdated Show resolved Hide resolved
@tigrannajaryan
Copy link
Member Author

Please have another look.

Copy link
Contributor

@ccaraman ccaraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pjanotti pjanotti merged commit 99ab342 into open-telemetry:master Aug 23, 2019
@tigrannajaryan tigrannajaryan deleted the feature/tigran/fanout branch August 23, 2019 00:18
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…#285)

* bump dependent module versions.

* update example hashes too.
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants