Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow golang pattern and name public function types with Func suffix #2880

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team April 1, 2021 21:40
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #2880 (ddb41ca) into main (4dcd2b8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2880   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         286      286           
  Lines       15088    15088           
=======================================
  Hits        13847    13847           
  Misses        849      849           
  Partials      392      392           
Impacted Files Coverage Δ
exporter/exporterhelper/common.go 100.00% <ø> (ø)
processor/processorhelper/processor.go 100.00% <ø> (ø)
receiver/scraperhelper/scraper.go 100.00% <ø> (ø)
component/componenthelper/component.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dcd2b8...ddb41ca. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@bogdandrutu bogdandrutu merged commit 64fe8f0 into open-telemetry:main Apr 13, 2021
@bogdandrutu bogdandrutu deleted the compfunc branch February 1, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants