Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename traces methods/objects to include Traces in Kafka receiver #2966

Conversation

sincejune
Copy link
Contributor

Description:
Renamed methods/objects used by Traces to include "Traces" in Kafka receiver.
Fixed #2944 (comment)

@sincejune sincejune requested a review from a team April 20, 2021 12:38
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #2966 (d432377) into main (0a2ea1b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2966   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         312      312           
  Lines       15445    15445           
=======================================
  Hits        14153    14153           
  Misses        883      883           
  Partials      409      409           
Impacted Files Coverage Δ
receiver/kafkareceiver/jaeger_unmarshaller.go 100.00% <ø> (ø)
receiver/kafkareceiver/otlp_unmarshaller.go 100.00% <ø> (ø)
receiver/kafkareceiver/zipkin_unmarshaller.go 92.59% <ø> (ø)
receiver/kafkareceiver/factory.go 100.00% <100.00%> (ø)
receiver/kafkareceiver/kafka_receiver.go 100.00% <100.00%> (ø)
receiver/kafkareceiver/unmarshaller.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2ea1b...d432377. Read the comment docs.

@bogdandrutu bogdandrutu merged commit cdebd4c into open-telemetry:main Apr 20, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
@sincejune sincejune deleted the rename-kafka-receiver-traces-methods branch October 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants