Honor Prometheus external labels #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get a review, @Aneurysm9 @odeke-em? |
Aneurysm9
approved these changes
May 10, 2021
odeke-em
approved these changes
May 10, 2021
|
cc @open-telemetry/collector-approvers, this is ready to review. |
dashpole
approved these changes
May 12, 2021
|
@open-telemetry/collector-approvers can you please review asap? Thanks! Ping @jpkrohling |
carlosalberto
approved these changes
May 13, 2021
alolita
added
the
ready-to-merge
|
Can someone merge this PR? It's been sitting here for a long time and is important for Prometheus compliance. cc @bogdandrutu |
|
@bogdandrutu can you please merge this PR? Its been reviewed and is awaiting to be merged. Many thanks. |
bogdandrutu
approved these changes
May 17, 2021
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-collector
that referenced
this pull request
May 17, 2021
|
For the record, I also missed the notification for this one. |
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
* Honor Prometheus external labels Add external labels to every scraped sample in the Prometheus receiver if user has external labels configured. Fixes open-telemetry#2904. * Fix typo * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add external labels to every scraped sample in the Prometheus receiver if user has external labels configured.
Fixes #2904.
Related to https://github.com/open-telemetry/opentelemetry-collector/issues/3016.