Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standarize Settings, Params and Parameters in Processors #3181

Conversation

pmatyjasek-sumo
Copy link
Contributor

@pmatyjasek-sumo pmatyjasek-sumo commented May 14, 2021

Description:
Continuation work from #2991
Fixes #2650
Replace ProcessorCreateParams with ProcessorCreateSettings.
Replace all dependencies in Processors.

Link to tracking Issue:
#2650

Testing:
Update unit tests

Documentation:
In code comments

@pmatyjasek-sumo pmatyjasek-sumo requested a review from a team May 14, 2021 13:15
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 22, 2021
@pmatyjasek-sumo pmatyjasek-sumo force-pushed the pm_standarize_settings_processors branch from bbfc87e to 9be09e0 Compare May 24, 2021 09:27
@bogdandrutu bogdandrutu removed the Stale label May 24, 2021
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@pmatyjasek-sumo pmatyjasek-sumo force-pushed the pm_standarize_settings_processors branch 2 times, most recently from ff06312 to 590e425 Compare May 31, 2021 09:16
Replace all dependencies in Processors.

Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com>
Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com>

# Conflicts:
#	CHANGELOG.md

# Conflicts:
#	CHANGELOG.md
@pmatyjasek-sumo pmatyjasek-sumo force-pushed the pm_standarize_settings_processors branch from 06e993a to ef148ec Compare June 2, 2021 10:26
@pmatyjasek-sumo
Copy link
Contributor Author

Rebase is done

@bogdandrutu bogdandrutu merged commit 017aa1d into open-telemetry:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize on params vs settings vs options
3 participants