Update CI jobs to not require contexts for PR builds #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@owais - Are you able to add in the changes from open-telemetry/opentelemetry-collector-contrib#3423 to the core collector? |
owais
changed the title
owais
commented
May 20, 2021
| @@ -14,5 +14,5 @@ else | |||
| curr="${TESTS[$i]}" | |||
| fi | |||
| done | |||
| MATRIX+="]}" | |||
| MATRIX+=",{\"test\":\"$curr\"}]}" | |||
There was a problem hiding this comment.
This script actually misses the last two load tests. This change ensures last two load tests are added to the matrix.
This commit ensures that PR builds will not use circleci contexts as any jobs depending on contexts can only be executed by otel members.
gramidt
approved these changes
May 20, 2021
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
This commit ensures that PR builds will not use circleci contexts as any jobs depending on contexts can only be executed by otel members.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the same fix to unblock community PRs as the following contrib PR: open-telemetry/opentelemetry-collector-contrib#3423