Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial implementation of pdatagrcp #3231

Merged
merged 2 commits into from
May 19, 2021
Merged

Add initial implementation of pdatagrcp #3231

merged 2 commits into from
May 19, 2021

Commits on May 19, 2021

  1. Add initial implementation of pdatagrcp 

    This is needed because if we split pdata, we will nolonger be able to depend on the InternalRep or generated proto classes (raw, grpc).

The pdatagrcp will eventually be public once we stabilize the API.

The API in the pdatagrcp package is inspired from the grpc generated classes and redirects all calls to the generated classes. Some simple renames:
* TraceService[Client|Server] -> Traces[Client|Server]
* MetricsService[Client|Server] -> Metrics[Client|Server]
* LogsService[Client|Server] -> Logs[Client|Server]

Other changes:
* Replace usages of grpc generated classes in otlpexporter to excercise this new package.
* Left some TODOs for the moment until this package is used more to determine the right API.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
    @bogdandrutu
    bogdandrutu committed May 19, 2021
    Configuration menu
    Copy the full SHA
    fa27faf View commit details
    Browse the repository at this point in the history

  2. Add details for the TODOs left 

    Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
    @bogdandrutu
    bogdandrutu committed May 19, 2021
    Configuration menu
    Copy the full SHA
    4a27e08 View commit details
    Browse the repository at this point in the history