Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otlpjson as a serializer implementation #3238

Merged
merged 1 commit into from
May 26, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team May 20, 2021 00:12
@bogdandrutu bogdandrutu marked this pull request as draft May 20, 2021 00:15
@bogdandrutu bogdandrutu force-pushed the jsonserializer branch 2 times, most recently from 5581599 to 4fceba5 Compare May 21, 2021 19:48
@bogdandrutu bogdandrutu marked this pull request as ready for review May 21, 2021 19:48
@carlosalberto
Copy link
Contributor

Out of curiosity: is this expected to be working eventually in the very same way as internal/otlptext? ;)

@bogdandrutu
Copy link
Member Author

@carlosalberto internal/otlptext is expected to work like this.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 6fa269a into open-telemetry:main May 26, 2021
@bogdandrutu bogdandrutu deleted the jsonserializer branch May 26, 2021 19:44
dashpole pushed a commit to dashpole/opentelemetry-collector that referenced this pull request Jun 14, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants