Move config.Parser to configparser.Parser, preparation for ParserProvider interface #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
approved these changes
May 25, 2021
mx-psi
approved these changes
May 26, 2021
pjanotti
approved these changes
May 26, 2021
…ider interface Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
…ider interface (open-telemetry#3304) Idea is that we will eventually move the https://github.com/open-telemetry/opentelemetry-collector/blob/main/service/parserprovider/provider.go#L25 in this package, so everything about config parsing is in this package. Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is that we will eventually move the https://github.com/open-telemetry/opentelemetry-collector/blob/main/service/parserprovider/provider.go#L25 in this package, so everything about config parsing is in this package.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com