Add telemetry for dropped data due to exporter sending queue overflow #3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
May 28, 2021
obsreport/obsreport_exporter.go
Outdated
Comment on lines
66
to
69
| // RecordTracesEnqueueFailure records number of spans that failed to be added to the sending queue. | ||
| func (eor *Exporter) RecordTracesEnqueueFailure(ctx context.Context, numSpans int) { | ||
| _ = stats.RecordWithTags(ctx, eor.mutators, obsmetrics.ExporterFailedToEnqueueSpans.M(int64(numSpans))) | ||
| } |
There was a problem hiding this comment.
I want to think a bit more about this API, do you know any simple way to make this "private API" (internal) for the moment until we better understand the need?
There was a problem hiding this comment.
Cannot think of any other way to arrange this without code duplication :(
There was a problem hiding this comment.
Temporarily migrated to make it private with some code duplication
dmitryax
force-pushed
the
expose-enqueue-failures-metric
branch
2 times, most recently
from
a27155f
to
e6c6e57
Compare
This change adds internal metrics for dropped spans, metric points and log records when exporter sending queue is full: - exporter/enqueue_failed_metric_points - exporter/enqueue_failed_spans - exporter/enqueue_failed_log_records
dmitryax
force-pushed
the
expose-enqueue-failures-metric
branch
3 times, most recently
from
2bb405a
to
78ca1b0
Compare
By moving them to the package where they are being used. It requires some code duplication
dmitryax
force-pushed
the
expose-enqueue-failures-metric
branch
from
78ca1b0
to
c882e64
Compare
bogdandrutu
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds internal metrics for dropped spans, metric points and log records when exporter sending queue is full: