Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the example config of attributes processor #3334

Conversation

Saber-W
Copy link
Member

@Saber-W Saber-W commented May 27, 2021

Description:
Update attributes in the config.yaml of attributes processor. So the regex value is consistent with the comment above it, as suggested in the issue.

Link to tracking Issue:
#2843

@Saber-W Saber-W requested a review from a team May 27, 2021 20:22
@Saber-W
Copy link
Member Author

Saber-W commented May 28, 2021

Copy link
Member

@gramidt gramidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 15, 2021
@tigrannajaryan
Copy link
Member

Please rebase from main.

@Saber-W Saber-W force-pushed the update-attributeprocessor-example branch from b8441d7 to 02ec262 Compare June 16, 2021 20:49
@Saber-W
Copy link
Member Author

Saber-W commented Jun 16, 2021

@tigrannajaryan Hi Tigran, I have rebased.

@github-actions github-actions bot removed the Stale label Jun 17, 2021
@tigrannajaryan tigrannajaryan merged commit 3f5c718 into open-telemetry:main Jun 17, 2021
@tigrannajaryan
Copy link
Member

Thank you @Saber-W

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants