Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Fix panic when not using NewCommand #4139

Merged
merged 7 commits into from
Sep 30, 2021

Commits on Sep 28, 2021

  1. Add default value to flags

    mx-psi committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    e734624 View commit details
    Browse the repository at this point in the history
  2. Add default for default parser provider

    The test does not trigger this panic since it is using a custom provider,
    but for consistency we can change it there too.
    mx-psi committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    c697c76 View commit details
    Browse the repository at this point in the history
  3. Empty commit to retrigger CI

    mx-psi committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    b0aa33a View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Configuration menu
    Copy the full SHA
    412d8f0 View commit details
    Browse the repository at this point in the history
  2. Empty commit to retrigger CI

    mx-psi committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    d279379 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Configuration menu
    Copy the full SHA
    e68a8dc View commit details
    Browse the repository at this point in the history
  2. Address review comment

    mx-psi committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    db35aea View commit details
    Browse the repository at this point in the history