Change Properties Provider to be a converter, does not match the Provider interface #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4666 +/- ##
==========================================
+ Coverage 90.65% 90.72% +0.06%
==========================================
Files 179 179
Lines 10644 10627 -17
==========================================
- Hits 9649 9641 -8
+ Misses 771 765 -6
+ Partials 224 221 -3
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
propasconverter
branch
from
2044964
to
ecceaa1
Compare
dmitryax
reviewed
Jan 11, 2022
bogdandrutu
force-pushed
the
propasconverter
branch
from
ecceaa1
to
a12cc63
Compare
dmitryax
approved these changes
Jan 11, 2022
…ider interface Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
propasconverter
branch
from
a12cc63
to
75a0c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves TODOs left in #4657
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com