Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to viper in comments #4731

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested review from a team and codeboten January 21, 2022 19:25
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #4731 (90d1d97) into main (459f156) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4731   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files         179      179           
  Lines       10687    10687           
=======================================
  Hits         9696     9696           
  Misses        770      770           
  Partials      221      221           
Impacted Files Coverage Δ
config/configmapprovider/properties.go 100.00% <ø> (ø)
internal/testcomponents/example_exporter.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 459f156...90d1d97. Read the comment docs.

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 21, 2022
@bogdandrutu bogdandrutu merged commit 1ce4e41 into open-telemetry:main Jan 21, 2022
@bogdandrutu bogdandrutu deleted the rmrefviper branch January 21, 2022 19:43
mx-psi pushed a commit that referenced this pull request Jun 28, 2024
#### Description
Now that
[4246](open-telemetry/opentelemetry.io#4246),
[4322](open-telemetry/opentelemetry.io#4322),
and [4529](open-telemetry/opentelemetry.io#4529)
have been merged, and the new [Internal
telemetry](https://opentelemetry.io/docs/collector/internal-telemetry/)
and
[Troubleshooting](https://opentelemetry.io/docs/collector/troubleshooting/)
pages are live, it's time to clean up the underlying Collector repo docs
so that the website is the single source of truth.

I've deleted any content that was moved to the website, and linked to
the relevant sections where possible. I've consolidated what content
remains in the observability.md file and left troubleshooting.md and
monitoring.md as stubs that point to the website.

I also searched the Collector repo for cross-references to these files
and adjusted links where appropriate.

~~Note that this PR is blocked by
[4731](open-telemetry/opentelemetry.io#4731
EDIT: #4731 is merged and no longer a blocker.

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #8886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants