Make component interfaces uniform #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia and
songy23
as code owners
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
==========================================
- Coverage 75.78% 75.76% -0.02%
==========================================
Files 120 120
Lines 7391 7431 +40
==========================================
+ Hits 5601 5630 +29
- Misses 1523 1534 +11
Partials 267 267
Continue to review full report at Codecov.
|
tigrannajaryan
force-pushed
the
feature/tigran/unified-component
branch
from
ff0d6d2 to
e9e0317
Compare
tigrannajaryan
changed the title
tigrannajaryan
force-pushed
the
feature/tigran/unified-component
branch
from
e9e0317 to
dc8d621
Compare
|
@open-telemetry/collector-maintainers please review. |
pjanotti
reviewed
Jan 7, 2020
pjanotti
reviewed
Jan 7, 2020
There was a problem hiding this comment.
I like it!
Probably not worth to do in the same PR but have you considered having a CreateReceiver factory method and using type assertion to check if a given receiver supports TraceReceiver and/or MetricsReceiver interfaces? I didn't think about all implications of this, but, it seems a path worth exploring.
tigrannajaryan
force-pushed
the
feature/tigran/unified-component
branch
from
dc8d621 to
4f02aeb
Compare
owais
approved these changes
Jan 8, 2020
This change fixes inconsistencies in component interfaces. Motivation: - Uniformness results in reduction of code that currently has to deal with differences. - Processor.Start is missing and is important for allowing processors to communicate with the Host. What's changed: - Introduced Component interface. - Unified Host interface. - Added a Start function to processors (via Component interface). - Start/Shutdown is now called for Processors from service start/shutdown. - Receivers, Exporters, Processors, Extensions now embed Component interface. - Replaced StartTraceReception/StartMetricsReception by single Start function for receivers. - Replaced StopTraceReception/StopMetricsReception by single Shutdown function for receivers. Note: before merging this we need to announce the change in Gitter since it breaks existing implementations in contrib (although the fix is easy). Resolves open-telemetry#477 Resolves open-telemetry#262
tigrannajaryan
force-pushed
the
feature/tigran/unified-component
branch
from
4f02aeb to
7399146
Compare
@pjanotti I didn't think about this. Can explore in the future. |
tigrannajaryan
changed the title
|
I am going to merge this. The change was announced in gitter. After merging this I will update the contrib repo. |
subnova
pushed a commit
to subnova/opentelemetry-collector
that referenced
this pull request
Jan 14, 2020
This change fixes inconsistencies in component interfaces. Motivation: - Uniformness results in reduction of code that currently has to deal with differences. - Processor.Start is missing and is important for allowing processors to communicate with the Host. What's changed: - Introduced Component interface. - Unified Host interface. - Added a Start function to processors (via Component interface). - Start/Shutdown is now called for Processors from service start/shutdown. - Receivers, Exporters, Processors, Extensions now embed Component interface. - Replaced StartTraceReception/StartMetricsReception by single Start function for receivers. - Replaced StopTraceReception/StopMetricsReception by single Shutdown function for receivers. Note: before merging this we need to announce the change in Gitter since it breaks existing implementations in contrib (although the fix is easy). Resolves open-telemetry#477 Resolves open-telemetry#262
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
* Update demo chart codeowners * Bump demo chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes inconsistencies in component interfaces. Motivation:
What's changed:
Note: before merging this we need to announce the change in Gitter since it breaks existing implementations in
contrib(although the fix is easy).Resolves #477
Resolves #262