Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[model/semconv] Add definitions for semantic conventions v1.9.0 #5090

Merged
merged 1 commit into from
Mar 29, 2022
Merged

[model/semconv] Add definitions for semantic conventions v1.9.0 #5090

merged 1 commit into from
Mar 29, 2022

Conversation

dmitryax
Copy link
Member

No description provided.

@dmitryax dmitryax requested review from a team and tigrannajaryan March 26, 2022 19:31
@codecov
Copy link

codecov bot commented Mar 26, 2022 •
edited
Loading

Codecov Report

Merging #5090 (97abaec) into main (7fe86bf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5090   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files         183      183           
  Lines       11023    11023           
=======================================
  Hits         9936     9936           
  Misses        865      865           
  Partials      222      222

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe86bf...97abaec. Read the comment docs.

@dmitryax
Copy link
Member Author

I would wait for confirmation from @Aneurysm9 as original author of the SemConv definitions that the change of SchemaURL is needed, or if there is any reason to keep the https://opentelemetry.io/schemas/v prefix.

@dmitryax dmitryax mentioned this pull request Mar 28, 2022
Merged
@dmitryax dmitryax marked this pull request as draft March 28, 2022 04:02
@tigrannajaryan
Copy link
Member

I would wait for confirmation from @Aneurysm9 as original author of the SemConv definitions that the change of SchemaURL is needed, or if there is any reason to keep the https://opentelemetry.io/schemas/v prefix.

@dmitryax I believe the "v" prefix should not be present. It is incorrectly added.

@dmitryax dmitryax marked this pull request as ready for review March 28, 2022 15:59
@dmitryax
Copy link
Member Author

@tigrannajaryan thanks for confirming

@dmitryax dmitryax added the ready-to-merge Code review completed; ready to merge by maintainers label Mar 28, 2022
@bogdandrutu bogdandrutu merged commit 55c365b into open-telemetry:main Mar 29, 2022
@mx-psi mx-psi mentioned this pull request Mar 29, 2022
Closed
@dmitryax dmitryax deleted the generate-semconv branch March 29, 2022 18:48
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
@dmitryax @Nicholaswang
[model/semconv] Add definitions for semantic conventions v1.9.0 (open…
2c1ebdc 
…-telemetry#5090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbandy cbandy cbandy left review comments

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
ready-to-merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dmitryax @tigrannajaryan @cbandy @codeboten @Aneurysm9 @bogdandrutu