-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ballast test cases by using cross-platform lib #61
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 69.67% 69.58% -0.09%
==========================================
Files 86 86
Lines 5606 5606
==========================================
- Hits 3906 3901 -5
- Misses 1481 1485 +4
- Partials 219 220 +1
Continue to review full report at Codecov.
|
Strange that it shows reduction in codecov. Also the build result does not seem to be reported from Travis to Github properly. |
@tigrannajaryan it had a typo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change itself looks good, need to check if the counter for Darwin is correct per offline conversation.
This should make the test work on the following platforms: - FreeBSD i386/amd64/arm - Linux i386/amd64/arm - Windows/amd64 - Darwin i386/amd64 - OpenBSD amd64 Fixes #58
UpdateThe test was working across platforms but not so reliably on Travis CI. It seems the testsuite and the Go compiler toolchain consuming very different amount of memory across different environments. We could get it to work but I don't think it would be worth the effort especially considering it would likely break in new environments and we would have to maintain it. I think it's better to have this as a standalone test that spins up a production collector instance and monitors it's memory usage. @pjanotti suggested we use the perf testbed for this and I think that makes a lot of sense. As a result this PR is just disabling the ballast test for now. We'll remove it once it is implemented as a perf test. |
The ballast test case unreliable across platforms so had to remove it. It'll be replaced with an external test case as leveraging the performance testbed. The latest version was working on Linux and macOS laptops but had a hard time on Travis CI. It seems the only reliable way to test ballast is to spin up an external collector process and monitor it's memory usage. This will be implemented as part one of the perf testbed cases.
I actually removed it completely to get rid of the dependency as there was no point in carrying it for nothing. |
I agree. This makes a lot of sense as an E2E test. |
* Add function_ref * Add function_ref
This should make the test work on the following platforms: