Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON marshaler emits enums as ints per spec reuqirements. #6339

Merged
merged 1 commit into from
Oct 18, 2022
Merged

JSON marshaler emits enums as ints per spec reuqirements. #6339

merged 1 commit into from
Oct 18, 2022

Conversation

bogdandrutu
Copy link
Member

Fixes #6338

@bogdandrutu bogdandrutu requested review from a team and Aneurysm9 October 18, 2022 00:08
@codecov
Copy link

codecov bot commented Oct 18, 2022 •
edited
Loading

Codecov Report

Base: 92.04% // Head: 92.04% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (40d258b) compared to base (4d44580).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6339   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         219      219           
  Lines       13244    13250    +6     
=======================================
+ Hits        12190    12196    +6     
  Misses        830      830           
  Partials      224      224
Impacted Files Coverage Δ
pdata/plog/json.go 100.00% <100.00%> (ø)
pdata/pmetric/json.go 82.35% <100.00%> (+2.35%) ⬆️
pdata/ptrace/json.go 82.35% <100.00%> (+2.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dmitryax
dmitryax reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it

.chloggen/enumsasints.yaml Outdated Show resolved Hide resolved
pdata/plog/json.go Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit c157b12 into open-telemetry:main Oct 18, 2022
@bogdandrutu bogdandrutu deleted the enumsasints branch October 18, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
go.opentelemetry.io/collector/pdata 1.0
Development

Successfully merging this pull request may close these issues.

JSON Marshaler must emit enums as ints
2 participants
@bogdandrutu @dmitryax