Instrument batch processor with Otel Go
#6423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paivagustavo
force-pushed
the
gustavo/instrument_batch_processor_with_otel_go
branch
from
124433e to
b440529
Compare
Codecov ReportBase: 91.12% // Head: 91.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6423 +/- ##
==========================================
- Coverage 91.12% 91.00% -0.12%
==========================================
Files 241 241
Lines 13887 14005 +118
==========================================
+ Hits 12654 12745 +91
- Misses 993 1011 +18
- Partials 240 249 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
codeboten
reviewed
Nov 3, 2022
paivagustavo
force-pushed
the
gustavo/instrument_batch_processor_with_otel_go
branch
from
6cb465c to
3c29b8e
Compare
paivagustavo
force-pushed
the
gustavo/instrument_batch_processor_with_otel_go
branch
2 times, most recently
from
c73536f to
79ba658
Compare
paivagustavo
requested review from
codeboten
and removed request for
jpkrohling
jmacd
reviewed
Nov 15, 2022
codeboten
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Thanks for addressing my comments @paivagustavo, please take a look at @jmacd's suggestion and resolve conflicts
fix imports spacing
paivagustavo
force-pushed
the
gustavo/instrument_batch_processor_with_otel_go
branch
from
79ba658 to
8aca1eb
Compare
jmacd
approved these changes
Nov 16, 2022
codeboten
deleted the
gustavo/instrument_batch_processor_with_otel_go
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
batchprocessor with OpenTelemetry Go.batch_send_size_bytesview of OpenCensus.Link to tracking Issue: part of #816
Testing:
view, to test instrumentation made by both OpenCensus and OpenTelemetry SDK.featuregateenabled/disabled.Note: There are some "whitespace" changes, so I suggest reviewers to hide those when reviewing, it was done to make existing tests to run one time for each SDK.