Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: move obsreport tests fixture to file #6473

Merged

Conversation

paivagustavo
Copy link
Member

Description: move tests fixture to file.

Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-collector/pull/6346/files#r1010963714

@paivagustavo paivagustavo requested review from a team and mx-psi November 3, 2022 16:25
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 91.54% // Head: 91.57% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (7ec186d) compared to base (4e29c76).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6473      +/-   ##
==========================================
+ Coverage   91.54%   91.57%   +0.02%     
==========================================
  Files         238      238              
  Lines       13737    13737              
==========================================
+ Hits        12576    12580       +4     
+ Misses        930      927       -3     
+ Partials      231      230       -1     
Impacted Files Coverage Δ
service/collector.go 78.26% <0.00%> (ø)
extension/ballastextension/memory_ballast.go 82.14% <0.00%> (ø)
processor/memorylimiterprocessor/memorylimiter.go 91.00% <0.00%> (+2.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 3, 2022
@bogdandrutu bogdandrutu merged commit 8ebfb42 into open-telemetry:main Nov 3, 2022
@paivagustavo paivagustavo deleted the gustavo/obsreport_test_fixture_file branch November 5, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants