Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error from pcommon.[Value|Map|Slice].FromRaw when unsupported type. #6579

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu marked this pull request as ready for review November 19, 2022 03:00
@bogdandrutu bogdandrutu requested review from a team and Aneurysm9 November 19, 2022 03:00
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…type.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 90.91% // Head: 90.91% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bd4d4df) compared to base (aaaa356).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6579   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files         241      241           
  Lines       14077    14082    +5     
=======================================
+ Hits        12798    12803    +5     
  Misses       1027     1027           
  Partials      252      252           
Impacted Files Coverage Δ
pdata/pcommon/common.go 93.58% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit e3509cd into open-telemetry:main Nov 19, 2022
@bogdandrutu bogdandrutu deleted the fromrawerror branch November 19, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants