Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve service Config types name #6787

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team and codeboten December 13, 2022 19:04
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 90.08% // Head: 90.08% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (dc1a2e5) compared to base (eb5f336).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6787   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files         246      246           
  Lines       14245    14246    +1     
=======================================
+ Hits        12833    12834    +1     
  Misses       1163     1163           
  Partials      249      249           
Impacted Files Coverage Δ
otelcol/config.go 100.00% <ø> (ø)
service/pipelines.go 95.16% <ø> (ø)
otelcol/unmarshaler.go 100.00% <100.00%> (ø)
service/config.go 100.00% <100.00%> (ø)
service/service.go 68.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wanted to raise this naming issue as well

@bogdandrutu bogdandrutu merged commit cfa49fc into open-telemetry:main Dec 15, 2022
@bogdandrutu bogdandrutu deleted the bettercfgnames branch December 15, 2022 18:38
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Dec 15, 2022
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Dec 15, 2022
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Dec 15, 2022
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this pull request Dec 15, 2022
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants