Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @djaglowski as approver, and make him work from the first week. #6885

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Add @djaglowski as approver, and make him work from the first week. #6885

merged 2 commits into from
Jan 4, 2023

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu
Add @djaglowski as approver
e153ad2 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu
Make @djaglowski work from first week
62f2455 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested review from a team and dmitryax January 4, 2023 02:50
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 91.03% // Head: 91.03% // No change to project coverage 👍

Coverage data is based on head (62f2455) compared to base (ba6d664).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6885   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         237      237           
  Lines       14327    14327           
=======================================
  Hits        13042    13042           
  Misses       1031     1031           
  Partials      254      254

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dmitryax
dmitryax approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dmitryax
Copy link
Member

dmitryax commented Jan 4, 2023

Thanks for replacing my shift! I just realized its the last day of my vacation

mx-psi
mx-psi approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codeboten
Copy link
Contributor

Just waiting on approval from @djaglowski 😄

@codeboten codeboten merged commit d8c9f24 into open-telemetry:main Jan 4, 2023
@bogdandrutu bogdandrutu deleted the adddaniel branch October 14, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@mx-psi mx-psi mx-psi approved these changes

@djaglowski djaglowski djaglowski approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bogdandrutu @dmitryax @codeboten @djaglowski @mx-psi