Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove go 1.18 support, bump minimum to go 1.19 and add testing for 1.20 #7151

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Feb 7, 2023

Fixes #7159

Signed-off-by: Alex Boten aboten@lightstep.com

Alex Boten added 2 commits February 7, 2023 12:50
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 90.84% // Head: 90.84% // No change to project coverage 👍

Coverage data is based on head (40d019a) compared to base (e769012).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7151   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         293      293           
  Lines       14302    14302           
=======================================
  Hits        12993    12993           
  Misses       1041     1041           
  Partials      268      268           
Impacted Files Coverage Δ
cmd/builder/internal/builder/main.go 59.57% <100.00%> (ø)
receiver/otlpreceiver/internal/logs/otlp.go 100.00% <0.00%> (ø)
receiver/otlpreceiver/internal/trace/otlp.go 100.00% <0.00%> (ø)
receiver/otlpreceiver/internal/metrics/otlp.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten marked this pull request as ready for review February 8, 2023 16:17
@codeboten codeboten requested review from a team and dmitryax February 8, 2023 16:17
@bogdandrutu bogdandrutu merged commit ead716a into open-telemetry:main Feb 8, 2023
@codeboten codeboten deleted the codeboten/go-1.20 branch February 8, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testing for Go 1.20, drop testing for Go 1.18
3 participants