Consolidate zpages constants #7275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
commented
Mar 2, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7275 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 293 293
Lines 14077 14077
=======================================
Hits 12796 12796
Misses 1013 1013
Partials 268 268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
djaglowski
force-pushed
the
mv-zpages-constants
branch
from
6a082bf
to
64f2c01
Compare
bogdandrutu
approved these changes
Mar 2, 2023
service/zpages.go
Outdated
Comment on lines
32
to
35
| zService = "servicez" | ||
| zPipeline = "pipelinez" | ||
| zExtension = "extensionz" | ||
| zFeature = "featurez" |
There was a problem hiding this comment.
I liked more with the "path" suffix.
There was a problem hiding this comment.
Updated. Should be good to go.
djaglowski
force-pushed
the
mv-zpages-constants
branch
2 times, most recently
from
a77d16a
to
d2f2b81
Compare
djaglowski
force-pushed
the
mv-zpages-constants
branch
from
d2f2b81
to
b882c34
Compare
bogdandrutu
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor cleanup of the zpages constants in the service package.