Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelcol] Add connectors to the components command #7809

Conversation

evan-bradley
Copy link
Contributor

Description:

Add connector components to the output of the components command.

Testing:

Unit tests

@evan-bradley evan-bradley requested review from a team and dmitryax June 1, 2023 20:32
@dmitryax
Copy link
Member

dmitryax commented Jun 1, 2023

Approved too soon. PTAL at the test failures

@evan-bradley evan-bradley force-pushed the add-connectors-to-components-command branch from 1b32428 to e7ccf85 Compare June 1, 2023 21:26
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (9104611) 90.97% compared to head (1b32428) 91.03%.

❗ Current head 1b32428 differs from pull request most recent head e7ccf85. Consider uploading reports for the commit e7ccf85 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7809      +/-   ##
==========================================
+ Coverage   90.97%   91.03%   +0.05%     
==========================================
  Files         295      295              
  Lines       14535    14538       +3     
==========================================
+ Hits        13223    13234      +11     
+ Misses       1048     1042       -6     
+ Partials      264      262       -2     
Impacted Files Coverage Δ
otelcol/command_components.go 90.32% <100.00%> (+1.03%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmitryax dmitryax merged commit 604c33d into open-telemetry:main Jun 1, 2023
@github-actions github-actions bot added this to the next release milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants