Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-creating the encoders WriteCloser for every request #7859

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team and dmitryax June 8, 2023 18:49
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 82.60% and no project coverage change.

Comparison is base (4b451e9) 91.14% compared to head (38ff7d1) 91.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7859   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files         296      297    +1     
  Lines       14914    14918    +4     
=======================================
+ Hits        13593    13597    +4     
  Misses       1045     1045           
  Partials      276      276           
Impacted Files Coverage Δ
config/confighttp/confighttp.go 87.27% <25.00%> (-1.69%) ⬇️
config/confighttp/compression.go 83.33% <63.63%> (-0.78%) ⬇️
config/confighttp/compressor.go 96.77% <96.77%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu force-pushed the compression branch 2 times, most recently from 404e2e1 to 25da20b Compare June 8, 2023 19:09
@bogdandrutu bogdandrutu force-pushed the compression branch 2 times, most recently from 54fb98b to c266f67 Compare June 9, 2023 15:23
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants