-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] add test helper to verify exporter behavior on errors #8143
[chore] add test helper to verify exporter behavior on errors #8143
Conversation
c6f5aa6
to
90c37f7
Compare
c05d798
to
4a8dbe1
Compare
Codecov ReportAttention:
... and 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
76f3c09
to
176ef2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please rebase
e41f6e2
to
a8ec112
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're almost done :) Thank you, @omrozowicz-splunk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omrozowicz-splunk couple last comments. Please rebase and I think we can merge it. Thank you!
b2a39e1
to
456a781
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @omrozowicz-splunk!
@omrozowicz-splunk one last thing. Can you please add |
Okaay, I can try to do that, but that will prolong this task even more - it requires a fake receiver and fake exporter and making the fake exporter send data to that fake receiver. Not sure if that will be super helpful, probably looking at the otlp example will be easier to understand. |
Unfortunately, if we merge this without the tests, the collector's build will marked as failing because the project's coverage will be below the threshold |
8515ea0
to
6805d7a
Compare
Hey @dmitryax, I added |
…od files, make received elements not exported
902ef99
to
2ead251
Compare
- Remove redundant exposed API - Simplify contract_checker_test.go - Remove excessive logging - Pass correct testing.T to subtests
2ead251
to
14e3d06
Compare
Thanks @omrozowicz-splunk! I added another commit to reduce the exposed API more and to simplify some tests. Let me know if something doesn’t look right for you. |
Description: Adding a test helper to test exporter behaviour on errors.
Link to tracking Issue: #7479
Will also fix: #7481
It is created based on the exporter receiver test: #7516
The exporter targets
mockReceiver
as an endpoint.The test cases covered here are: