[exporterhelper] Add observability to the new exporter helper #8244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8244 +/- ##
=======================================
Coverage 90.17% 90.18%
=======================================
Files 302 302
Lines 15733 15766 +33
=======================================
+ Hits 14188 14218 +30
- Misses 1253 1254 +1
- Partials 292 294 +2
☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
exporter-v2-enable-observability
branch
from
7481798
to
a29e672
Compare
This change adds collector's internal metrics and tracing to the new request-based exporter helpers. Only those metrics and traces are added that already adopted by the existing exporter helpers for backward compatibility. The new exporter helpers can and should expose more metrics, e.g. for tracking converter errors.
dmitryax
force-pushed
the
exporter-v2-enable-observability
branch
from
a29e672
to
774e65a
Compare
codeboten
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds collector's internal metrics and tracing to the new request-based exporter helpers. Only those metrics and traces are added that are already adopted by the existing exporter helpers for backward compatibility. The new exporter helpers can and should expose more metrics in the future, e.g. for tracking converter errors.
This PR is built on top of #8178
Only the second commit contains exclusive changes
Tracking Issue: #8122