[confighttp] Add option to disable HTTP keep-alives #8274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a changelog entry. |
atoulme
reviewed
Aug 23, 2023
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
kasia-kujawa
force-pushed
the
kkujawa_disable_keep_alives
branch
2 times, most recently
from
e154a06 to
80f69ad
Compare
|
@bogdandrutu Could you take a look at this pull request? |
andrzej-stencel
approved these changes
Sep 1, 2023
atoulme
approved these changes
Sep 1, 2023
kasia-kujawa
force-pushed
the
kkujawa_disable_keep_alives
branch
2 times, most recently
from
6ef9dc4 to
bffd17c
Compare
jpkrohling
approved these changes
Sep 5, 2023
|
@open-telemetry/collector-maintainers, I believe this is ready to be merged. |
jpkrohling
added
the
ready-to-merge
Aneurysm9
reviewed
Sep 5, 2023
kasia-kujawa
force-pushed
the
kkujawa_disable_keep_alives
branch
from
bffd17c to
50d445f
Compare
codeboten
reviewed
Sep 6, 2023
codeboten
approved these changes
Sep 6, 2023
I would prefer not to add this configuration option at all, but don't feel strongly enough to block this PR, so I'll simply decline to approve it. I'm not sure that logging a warning when this option is enabled would be more than noise. Hopefully someone enabling this option has a better understanding of their environment than we do and understands what they're buying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add option to disable HTTP keep-alives which helps in better load balancing in k8s clusters when otlphttp exports are used to send logs to otlp receivers
Link to tracking Issue: #8260