Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add error message on parsing bad protobuf response #8283

Merged

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Aug 24, 2023

Fixes #8282

@atoulme atoulme requested review from a team and bogdandrutu August 24, 2023 15:37
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4d36e23) 90.14% compared to head (d729e40) 90.14%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8283   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files         302      302           
  Lines       15766    15775    +9     
=======================================
+ Hits        14212    14221    +9     
  Misses       1259     1259           
  Partials      295      295           
Files Changed Coverage Δ
exporter/otlphttpexporter/otlp.go 92.34% <100.00%> (+0.36%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme atoulme force-pushed the add_error_message_on_parsing_protobuf branch from 97d8c2b to d729e40 Compare August 24, 2023 15:44
@codeboten codeboten merged commit 26c150c into open-telemetry:main Aug 24, 2023
@github-actions github-actions bot added this to the next release milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make parsing response error clear
3 participants