[exporterhelper] Convert internal request interface into a struct #8435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
dmitryax
force-pushed
the
refactor-request
branch
5 times, most recently
from
26e138f
to
d556a2d
Compare
atoulme
reviewed
Sep 14, 2023
atoulme
reviewed
Sep 14, 2023
At this point we have two interfaces: public and internal. Each interface have their own implementation which makes it hard to read. This change replaces the internal interface with a struct embedding the public interface. This requires moving the public interface to a separate package which makes the module structure cleaner anyway
dmitryax
force-pushed
the
refactor-request
branch
from
d556a2d
to
66803d4
Compare
bogdandrutu
reviewed
Sep 14, 2023
| change_type: breaking | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) | ||
| component: exporterhelper |
There was a problem hiding this comment.
You can avoid this for the moment, by duplicating the interfaces for the moment since that works in go. I think is better to postpone a bit this, since I think with the new Queue interface we can make the current internal depend on the main package not the other way around.
There was a problem hiding this comment.
If you don't like the duplicate code, using aliases also is an option.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point, we have two interfaces for request: public and internal. There is no need to have the internal interface. Replacing it with a struct makes the logic easier to follow.
This change replaces the internal interface with a struct embedding the public interface. This requires moving the public interface to a separate package which makes the module structure cleaner anyway.
It also adds a new optional request interface to handle partial failures.
Updates #8122