Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metric count methods for implicit metrics type #883

Conversation

dmitryax
Copy link
Member

No description provided.

@dmitryax dmitryax force-pushed the fix/dmitryax/fix-opaque-metrics-count branch from 0fb306b to 9fa6c7c Compare April 28, 2020 01:39
@codecov-io
Copy link

Codecov Report

Merging #883 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
+ Coverage   85.91%   85.97%   +0.05%     
==========================================
  Files         162      162              
  Lines       12946    12948       +2     
==========================================
+ Hits        11123    11132       +9     
+ Misses       1404     1395       -9     
- Partials      419      421       +2     
Impacted Files Coverage Δ
consumer/pdatautil/pdatautil.go 81.53% <100.00%> (+18.04%) ⬆️
translator/internaldata/resource_to_oc.go 70.58% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4b823...9fa6c7c. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit c7c58b3 into open-telemetry:master Apr 28, 2020
@bogdandrutu
Copy link
Member

@dmitryax thanks for this.

wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…lemetry#883)

* Bump github.com/itchyny/gojq from 0.10.3 to 0.10.4 in /tools

Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.10.3 to 0.10.4.
- [Release notes](https://github.com/itchyny/gojq/releases)
- [Changelog](https://github.com/itchyny/gojq/blob/master/CHANGELOG.md)
- [Commits](itchyny/gojq@v0.10.3...v0.10.4)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#883)

Bumps [boto3](https://github.com/boto/boto3) from 1.19.2 to 1.19.3.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.19.2...1.19.3)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants