Add zpages for service (servicez, pipelinez, extensionz) #894
Conversation
bogdandrutu
commented
Apr 30, 2020
bogdandrutu
commented
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
requested review from
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Code generated by "esc -pkg internal -o resources.go templates/"; DO NOT EDIT. |
There was a problem hiding this comment.
I can avoid submitting this generated code. Add it as required step in make to re-generate this file if not present, and add it to .gitignore.
There was a problem hiding this comment.
So right now does it depend on the dev to update this when the templates are updated?
There was a problem hiding this comment.
Yes, also I could not find a way to add the copyright so an extra step is required. I kind of like it to generate this every time, but that may be annoying for ide users if they don't use make
There was a problem hiding this comment.
What about a test to ensure that the version matches all the template files (just compare FS(true) vs FS(false))? In case of failure, the test should tell how to re-generate the file (including make to add header).
There was a problem hiding this comment.
Was not trivial calling twice to create a template from the same data returns different objects that the assert.Equal sees them as different, sorry I will merge as is, we can improve later.
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Code generated by "esc -pkg internal -o resources.go templates/"; DO NOT EDIT. |
There was a problem hiding this comment.
So right now does it depend on the dev to update this when the templates are updated?
| ) | ||
|
|
||
| var ( | ||
| fs = FS(false) |
There was a problem hiding this comment.
Suggestion: rename fs to indicate that is actually reading from embedded assets, alternatively add a comment to indicate what false means in this case.
There was a problem hiding this comment.
You cannot call with "true" from production code, because the file will not be present in the final binary. So need to call from the embedded data. I think this does not require comment, only tests should use true.
…try#894) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
…y#894) Bumps [boto3](https://github.com/boto/boto3) from 1.19.4 to 1.19.5. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.19.4...1.19.5) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
