bug: fix flaky test TestQueuedRetry_RequeuingEnabled #8989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8989 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 315 315
Lines 17117 17117
=======================================
Hits 15672 15672
Misses 1150 1150
Partials 295 295 ☔ View full report in Codecov by Sentry. |
pantuza
pushed a commit
to pantuza/opentelemetry-collector
that referenced
this pull request
Dec 8, 2023
…8989) fixes a flaky test Fixing a bug - TestQueuedRetry_RequeuingEnabled has been failing occasionally. Upon investigation, `be.send` calls the underlying `observabilityConsumerSender.send` which calls `wg.Done()`, so we need to add `wg.Add(1)` before that Fixes open-telemetry#6624 **Testing:** Ran the same test multiple times before/after change: `go test -race -run TestQueuedRetry_RequeuingEnabled -count 1000`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: fixes a flaky test
Fixing a bug - TestQueuedRetry_RequeuingEnabled has been failing occasionally. Upon investigation,
be.sendcalls the underlyingobservabilityConsumerSender.sendwhich callswg.Done(), so we need to addwg.Add(1)before thatLink to tracking Issue: #6624
Testing: Ran the same test multiple times before/after change:
go test -race -run TestQueuedRetry_RequeuingEnabled -count 1000Documentation: N/A