-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] remove unused opencensus code #9108
[chore] remove unused opencensus code #9108
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9108 +/- ##
==========================================
+ Coverage 90.18% 90.24% +0.05%
==========================================
Files 345 344 -1
Lines 18019 17932 -87
==========================================
- Hits 16251 16182 -69
+ Misses 1438 1421 -17
+ Partials 330 329 -1 ☔ View full report in Codecov by Sentry. |
I think this needs to be merged after we remove the gate. So 3-4 versions? |
@bogdandrutu correct, this PR is after #9102 which will be merged after v0.92.0 is released |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
fa74b6e
to
9849e46
Compare
9849e46
to
2a0ede5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR, lots of code going away :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🎉
We can also remove goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")
from the goleak tests now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting!
This is cleaning up opencensus code after the feature gate is marked stable. Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
2a0ede5
to
01b1da2
Compare
Follows #9102